[PATCH] D34177: [DWARF] Partial verification for .apple_names accelerator table in llvm-dwarfdump output.

[Spyridoula Gravani via Phabricator via llvm-commits]

sgravani marked 4 inline comments as done.
sgravani added inline comments.


================
Comment at: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp:290-293
+  if (!AppleNames.extract()) {
+    OS << "error: cannot extract .apple_names accelerator table\n";
+    return false;
+  }
----------------
dblaikie wrote:
> Is this error produced when the section is not present? Is that the right behavior/does this need an error in that case?
In such a case, we should not have any output message. 
Thanks for noticing! fixed it in new commit.


================
Comment at: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp:310
+  }
+  return NumAppleNamesErrors == 0;
+}
----------------
dblaikie wrote:
> Probably use a boolean flag if that's the only thing that matters? ("HasErrors"?)
I prefer to stay consistent with the naming in the other handle[section] functions in the class.


Repository:
  rL LLVM

https://reviews.llvm.org/D34177