[PATCH] D34288: [COFF] Drop unused comdat sections when GC is turned off

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 12:55:33 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/Chunks.cpp:236-239
+    if (Discarded)
+      message("Discarded comdat symbol " + Sym->getName());
+    else if (!Live)
+      message("Discarded " + Sym->getName());
----------------
Nice improvement!



https://reviews.llvm.org/D34288





More information about the llvm-commits mailing list