[PATCH] D34265: Switch external cvtres.exe for llvm's own resource library.In this patch, I flip the switch in DriverUtils from using the externalcvtres.exe tool to using the Windows Resource library in llvm.I also fixed a bug where .rsrc sections were...

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 11:06:08 PDT 2017


ecbeckmann added a comment.

In https://reviews.llvm.org/D34265#782500, @ruiu wrote:

> The first line of a commit message should be shorter than that is now. If you look at other commits, you'll find that their first lines are usually less than 80 or 100 characters.


I meant the title should be "Switch external cvtres.exe for llvm's own resource library" which is less than 80 characters.


https://reviews.llvm.org/D34265





More information about the llvm-commits mailing list