[PATCH] D34144: [CodeGen] Add generic MacroFusion pass.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks again for the feedback!



================
Comment at: lib/CodeGen/MacroFusion.cpp:77-79
+    // Ignore dependencies that don't enforce ordering.
+    if (Dep.isWeak())
+      continue;
----------------
MatzeB wrote:
> Maybe we should even go for `if (Dep.getKind() != Data)` at least I can't imagine right now how anti or output dependencies could lead to macrofusion.
I think we have to consider Order dependencies as well, because Order dependencies are used between compare and branch instructions, which should be fused on X86.


https://reviews.llvm.org/D34144