[PATCH] D34240: [WebAssembly] Expansion of llvm.umul.overflow with i64 type operands.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added subscribers: llvm-commits, efriedma.
efriedma edited reviewers, added: efriedma; removed: eli.friedman.
efriedma added a comment.

Please make sure to put llvm-commits in the subscriber list when you post a patch.

The changes to call lowering are kind of nasty; I'll sleep on it to see if I come up with a better idea.



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3564
+      BottomHalf = Ret.getOperand(0);
+      TopHalf = Ret.getOperand(1);
     }
----------------
vadimcn wrote:
> So this assumes that the type of node node returned by ExpandLibCall is known and not going to change?   Seems a bit dangerous to me...
Yes, definitely wrong: consider the case where the double-width type is legal.


https://reviews.llvm.org/D34240