[PATCH] D34048: [PowerPC] Eliminate compares - add i32 sext/zext handling for SETLE/SETGE

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2816
+// parameters for whether the RHS is -1/0/1.
+static void swapAndReset(SDValue &LHS, SDValue &RHS, bool &IsRHSZero,
+                         bool &IsRHSOne, bool &IsRHSNegOne) {
----------------
nemanjai wrote:
> I realize that the three by-ref bool's makes this signature look kind of busy. Perhaps it would be better to just encode these as bits in a single `char` or something along those lines?
You don't appear to use the values anywhere after they're set or am I missing something?


Repository:
  rL LLVM

https://reviews.llvm.org/D34048