[PATCH] D34265: Switch external cvtres.exe for llvm's own resource library.In this patch, I flip the switch in DriverUtils from using the externalcvtres.exe tool to using the Windows Resource library in llvm.I also fixed a bug where .rsrc sections were...

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 18:47:13 PDT 2017


ecbeckmann created this revision.

...marked as discardable
memory and therefore were placed in the wrong order in the final PE.

Furthermore, I modified WindowsResource to write the coff directly to a
memory buffer instead of to file, also had it use the machine types
already declared in COFF.h instead creating my own enum.

Changed WindowsResourceCOFFWriter to write to a memory buffer instead of file.  Also got rid of my own Machine enum and use the one defined in COFF.h


https://reviews.llvm.org/D34265

Files:
  lld/COFF/DriverUtils.cpp
  lld/test/COFF/resource.test
  lld/test/lit.cfg
  llvm/include/llvm/Object/WindowsResource.h
  llvm/lib/Object/WindowsResource.cpp
  llvm/tools/llvm-cvtres/llvm-cvtres.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34265.102770.patch
Type: text/x-patch
Size: 11474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170616/78215a21/attachment.bin>


More information about the llvm-commits mailing list