[PATCH] D34168: [cfi] CFI-ICall for ThinLTO.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 17:05:11 PDT 2017


pcc added a comment.

Still LGTM



================
Comment at: test/Transforms/LowerTypeTests/Inputs/use-typeid1-typeid2.yaml:4
   42:
-    - Live: true
+    - Live: false
       TypeTests: [14276520915468743435, 15427464259790519041] # guid("typeid1"), guid("typeid2")
----------------
Why did you change this to false?

Presumably the test still passes because WithGlobalValueDeadStripping is false?


Repository:
  rL LLVM

https://reviews.llvm.org/D34168





More information about the llvm-commits mailing list