[PATCH] D34257: [PDB] Start emitting source file and line information

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 16:11:44 PDT 2017


rnk created this revision.
Herald added a subscriber: hiraditya.

This is a first step towards getting line info to show up in VS and
windbg. So far, only llvm-pdbutil can parse the PDBs that we produce.
cvdump doesn't like something about our file checksum tables. I'll have
to dig into that next.

There's a lot of room for improvement in this code. The linker really
doesn't need to be doing this much deserialization. All it needs to do
is to copy the line tables and relocate them in the PDB. Currently we
copy the line tables, relocate them, deserialize them, and then use
high-level APIs to insert them into the PDB. All of that work is
basically unnecessary, but it's a start.


https://reviews.llvm.org/D34257

Files:
  lld/COFF/Chunks.h
  lld/COFF/PDB.cpp
  lld/test/COFF/Inputs/pdb_lines_1.obj
  lld/test/COFF/Inputs/pdb_lines_2.obj
  lld/test/COFF/pdb-source-lines.test
  lld/test/COFF/pdb.test
  llvm/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
  llvm/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34257.102744.patch
Type: text/x-patch
Size: 21785 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170615/dfffb29b/attachment.bin>


More information about the llvm-commits mailing list