[PATCH] D34160: [Power9] Exploit vinserth instruction

[Tony Jiang via Phabricator via llvm-commits]

jtony added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.h:515
+    bool isVINSERTHMask(ShuffleVectorSDNode *N, unsigned &ShiftElts,
+                        unsigned &InsertAtByte, bool &Swap, bool IsLE);
+
----------------
The community doesn't like the bool parameters here. But I am not sure whether we must remove them or it is just nice to do. 


================
Comment at: test/CodeGen/PowerPC/p9-vinsert-vextract.ll:8
+entry:
+; CHECK-LABEL: _Z27shuffle_vector_halfword_0_8Dv8_sS_
+; CHECK: vsldoi 3, 3, 3, 8
----------------
I would prefer to use non-mangled function names to make it more readable. I think you can just regenerate the IR from c source  file instead of cpp file.


Repository:
  rL LLVM

https://reviews.llvm.org/D34160