[PATCH] D33680: [ELF] - Resolve references properly when using .symver directive

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 13:17:19 PDT 2017


I actually find the loop simpler than the temp vector. The vector still
needs a comment, and with a comment the loop is just as easy to
understand.

Cheers,
Rafael

George Rimar <grimar at accesssoftek.com> writes:
> Yes, that is true for sure, but it complicates logic, no ?
>
> Temp vector still keep it simple,
> though if you think it is really better, I have probably no major arguments not to do that,
> it is a matter of taste it seems.
>
> Rui, will you be ok to do this change then ?
>
> George.


More information about the llvm-commits mailing list