[PATCH] D34245: [PowerPC] Refine the checking for emiting TOC restore nops and Tail-Call eligibility.

Graham Yiu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 13:08:07 PDT 2017


gyiu added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:4254
+static bool
+shouldAssumeDifferentTOC(const Function *Caller, SDValue Callee,
+                                     const TargetMachine &TM) {
----------------
Should we just move the code from this function to the existing resideInSameSection() function and rename the function itself?  I see in there we're also checking 

    GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(Callee);
    if (!G)
      return true;


Repository:
  rL LLVM

https://reviews.llvm.org/D34245





More information about the llvm-commits mailing list