[PATCH] D34220: [AArch64] Prefer B.cond to CBZ/CBNZ/TBZ/TBNZ when NZCV flags can be set for "free"

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 11:53:36 PDT 2017


From our side I would expect this to only have neutral or positive effects to the point where I think we can simply monitor the greendragon builds for perf changes.

- Matthias

> On Jun 15, 2017, at 11:13 AM, Chad Rosier via Phabricator via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> mcrosier added a comment.
> 
> In https://reviews.llvm.org/D34220#781363, @meadori wrote:
> 
>> RE: the feature flag statement.  Unless we know that this is a win all supported sub-targets (micro-architectures), then it seems like a feature flag would be the way to go, right?
> 
> 
> Yes, I think this is reasonable.  I left it off initially assuming it would be easier for other sub-target owners to test, but if the consensus is this should be sub-target specific, I'll add the feature flag accordingly.
> 
> 
> https://reviews.llvm.org/D34220
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list