[PATCH] D34221: [ELF] - Resolve references properly when using .symver directive (2)

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 11:46:43 PDT 2017


I prefer the bool return because it is less duplication. Otherwise we
have two places in the code that know that @@ has special meaning.

Cheers,
Rafael

Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> I don't think we should return a `bool` value from a parser function unless it really improves performance. Essentially it is a speed hack, so it needs to be proven that it is effective.
>
>
> https://reviews.llvm.org/D34221


More information about the llvm-commits mailing list