[PATCH] D34057: [TargetTransformInfo, API] Add optional list of operands to TTI::getUserCost

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 15:55:21 PDT 2017


efriedma added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:229
+  int getUserCost(const User *U,
+                  ArrayRef<const Value *> Operands =
+                      ArrayRef<const Value *>()) const;
----------------
Not sure I like the way this default argument works... too easy to mess up the "if (Operands.empty())" check.  Maybe add a one-argument overload that builds the list and calls the two-argument version?


https://reviews.llvm.org/D34057





More information about the llvm-commits mailing list