[PATCH] D34135: [LVI] Add initial result to avoid infinite getValueFromCondition recursion

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 12:30:05 PDT 2017


dberlin added a comment.

In https://reviews.llvm.org/D34135#780596, @efriedma wrote:

> > If the issue in JumpThreading is determining reachability at all times
>
> Yes, that's the primary issue.  If we had some cheap way to make JumpThreading avoid visiting unreachable blocks, that would be fine. JumpThreading already has code to kill off unreachable blocks, but it only runs once per iteration of the pass (because it takes O(N) time, where N is the number of CFG edges in the function).


Can't you just tell LVI the blocks are dead without them being dead?

> If the dynamic DomTree work solves that, that fine, but I'm not sure it makes sense to block this patch indefinitely on that.

FWIW: I expect that code to start being submitted in the next week :P
I don't expect it to take all that long.


https://reviews.llvm.org/D34135





More information about the llvm-commits mailing list