[PATCH] D34160: [Power9] Exploit vinserth instruction

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 12:03:42 PDT 2017


lei added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:1652
+  // Go through the mask of half-words to find an element that's being moved
+  // from one vector to the other
+  for (unsigned i = 0; i < NumHalfWords; ++i) {
----------------
nit: don't forget the "." :)


================
Comment at: test/CodeGen/PowerPC/p9-vinsert-vextract.ll:5
+; RUN:   -verify-machineinstrs < %s | FileCheck %s --check-prefix=CHECK-BE
+
+define <8 x i16> @_Z27shuffle_vector_halfword_0_8Dv8_sS_(<8 x i16> %a, <8 x i16> %b) {
----------------
Can you add a short description of what each of these functions are testing?


Repository:
  rL LLVM

https://reviews.llvm.org/D34160





More information about the llvm-commits mailing list