[PATCH] D33680: [ELF] - Resolve references properly when using .symver directive

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 10:32:21 PDT 2017


>I preferred the version where parseSymbolVersion returned null. Doing two
>scans over the name doesn't seem like a good idea.
>
>Rui, would you be OK with this patch but with parseSymbolVersion
>returning a bool instead of having a isDefaultVersion? We can always try
>to improve it afterwards.
>
>Cheers,
>Rafael

Returning bool you mean, I think.

I can upload such version in hext hour or two, so we can choose one from 3.

George.


More information about the llvm-commits mailing list