[PATCH] D34136: [Solaris] replace Solaris.h hack with a set of better hacks

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 03:08:55 PDT 2017


fedor.sergeev added a comment.

Perhaps, the use of `__BYTE_ORDER__` in ItaniumDemangle.cpp is dictated by its declared "independence":

  // It also has no dependencies on the rest of llvm. It is implemented this way
  // so that it can be easily reused in libcxxabi.

I was going to adapt it to Endian.h use, and now I'm not that sure.
Anyway, that should be a separate bugfix.

I believe I'm done here :-)


https://reviews.llvm.org/D34136





More information about the llvm-commits mailing list