[PATCH] D33773: [ARM] llc -arm-execute-only with floating point runs into UNREACHABLE

Christof Douma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 02:40:31 PDT 2017


christof added a comment.

I was about to approve it but, I have 1 little nitpick that I almost missed. Sorry for the dribble feed. It's about the naming of the global.



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:2690
+                                 getFunction()->getParent());
+    auto L = Twine(DAG.getDataLayout().getPrivateGlobalPrefix()) + "PC" +
+             Twine(DAG.getMachineFunction().getFunctionNumber()) + "_" +
----------------
I expect you meant to use `CP` (from ConstantPool) or something like that instead?


https://reviews.llvm.org/D33773





More information about the llvm-commits mailing list