[PATCH] D34142: [ARM] Add macro fusion for AES instructions.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Target/ARM/ARMMacroFusion.cpp:41
+
+  if (ST.hasFuseAES())
+    // Fuse AES crypto operations.
----------------
javed.absar wrote:
> Should this check be upfront so it comes out immediately? 
> 
> In fact, to TargetMachine.cpp, for efficiency ?
> const ARMSubtarget &ST = C->MF->getSubtarget<ARMSubtarget>();
> if (ST.hasFuseAES()) 
>   DAG->addMutation(createARMMacroFusionDAGMutation());
Yes! I'll add a check before adding the DAG mutation. I think it makes sense to keep the check here as well though, in case we add fusion for other instructions as well.


https://reviews.llvm.org/D34142