[PATCH] D34180: [ASan] Move rss_limit_is_exceeded_ flag to ASan.

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 16:29:35 PDT 2017


alekseyshl added a comment.

In https://reviews.llvm.org/D34180#779694, @kcc wrote:

> Why? 
>  It would be lovely to have the same flag work in other sanitizers...


Yep, other sanitizers need this functionality too, but the current way is pretty ugly (hinted by "bool check_rss_limit = false" parameter). I'd rather have the flag and the callback in sanitizer_allocator.cc, but first I'd like to finish changes addressing allocator_may_return_null issues (in a similar way, trying to move may_return_null_ flag out of the generic allocator) and then revisit RSS limit behavior.


https://reviews.llvm.org/D34180





More information about the llvm-commits mailing list