[PATCH] D32720: [LICM] Introduce a finer granularity option to compute early exits.

[Daniel Berlin via llvm-commits]

On Tue, Jun 13, 2017 at 2:01 PM, Eli Friedman via Phabricator <
reviews at reviews.llvm.org> wrote:

> efriedma added inline comments.
>
>
> ================
> Comment at: include/llvm/Transforms/Utils/OrderedInstructions.h:40
> +  /// Constructors.
> +  OrderedInstructions() = default;
>    OrderedInstructions(DominatorTree *DT) : DT(DT) {}
> ----------------
> Not sure I like this constructor... easy to misuse.
>

IMHO, we always require DT.

Is there anything that wants local but not global dominance?

It's usually IMHO, the other way around, things have global dominance and
then want local.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170613/e312fca2/attachment.html>