[PATCH] D34159: Fix a bug introduced in r305092 on big-endian systems.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 13:56:33 PDT 2017


ruiu added inline comments.


================
Comment at: llvm/lib/Object/WindowsResource.cpp:694
   uint32_t TotalStringTableSize = 0;
   for (auto String : StringTable) {
     uint16_t Length = String.size();
----------------
Don't you want to make this a reference? You are making a copy of a vector.


Repository:
  rL LLVM

https://reviews.llvm.org/D34159





More information about the llvm-commits mailing list