[PATCH] D34149: [ASAN] ASAN is not properly calling libbacktrace to symbolize program

[Denis Khalikov via Phabricator via llvm-commits]

denis13 added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libbacktrace.cc:113
   SymbolizeCodeCallbackArg *cdata = (SymbolizeCodeCallbackArg *)vdata;
+  if (function != NULL && cdata->frames_symbolized > 0)
+    return 0;
----------------
m.ostapenko wrote:
> This doesn't look correct to me. Why do we bail out if function is not NULL? Shouldn't we use `(!function && cdata->frames_symbolized > 0)` istead? Also please include more context into the patch (git diff -U999999) or something like that.
Thanks, my fault.


https://reviews.llvm.org/D34149