[PATCH] D34136: [Solaris] replace Solaris.h hack with a set of better hacks

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 06:39:00 PDT 2017

fedor.sergeev marked an inline comment as done.
fedor.sergeev added a comment.

Ahem... I'm not sure that "Support/Solaris/sys/regset.h" is a right name for this module thing.
The header is being included through -I <LLVM_MAIN_DIR>/include/llvm/Support/Solaris path, and its relative name is "sys/regset.h".

Besides, it does belong to the Support module in any practical way.

To me it is more akin to normal system headers.
We should not be mentioning any system headers in this modulemap thing.


More information about the llvm-commits mailing list