[PATCH] D34136: [Solaris] replace Solaris.h hack with a set of better hacks

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: include/llvm/module.modulemap:279
-    // Exclude this; it's only included on Solaris.
-    exclude header "Support/Solaris.h"
-
----------------
fedor.sergeev wrote:
> krytarowski wrote:
> > Do we want to install globally `Solaris/sys/regset.h`? Is it needed by Clang, LLDB or other projects?
> I dont quite understand all the module implications, but Solaris/sys/regset.h is just a crude fix for system sys/regset.h.
> I dont really see how it belongs to LLVM modules.
> 
> Also, currently there are no uses of regset.h outside of Solaris.h (as git grep in monorepo tells me).
> So it is just a guard against possible future misuse.
> It is very likely that it will never ever be used.
Then we should blacklist this header from installing globally.

```
exclude header "Support/Solaris/sys/regset.h"
```


https://reviews.llvm.org/D34136