[PATCH] D34087: [X86] EltsFromConsecutiveLoads - detect split loads without a common load base (PR32940)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D34087#777942, @niravd wrote:

> It looks like this is really an issue of  "areNonVolatileConsecutiveLoads" not being clever enough. BaseIndexOffset in DAGCombiner should do better. I'd favor moving BaseIndexOffset out of the DAG Combiner and rewriting areNonVolatileConsecutiveLoads off of that.


Are you suggesting we move BaseIndexOffset to a header so that it can be used in SelectionDAG as well or move all uses from DAGCombiner.cpp into SelectionDAG.cpp (load combines, store merge, neighbour chains etc.)?


Repository:
  rL LLVM

https://reviews.llvm.org/D34087