[PATCH] D33059: Create an shared include directory for gtest helper functions

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 02:14:31 PDT 2017

labath added a comment.

In https://reviews.llvm.org/D33059#778722, @chandlerc wrote:

> In https://reviews.llvm.org/D33059#778716, @labath wrote:
> > I think it is possible to avoid the explosion of `EXPECT/ASSERT_THAT_<FOO>` macros (I can't think of any right now, but I'm sure something will crop up eventually, which will require specific handling).
> There are a lot of things we can investigate to make this better. However, I don't think they belong in this patch. This patch is *mostly* about consolidating where things live to a common home. It does so. It updates some custom macro expectations to be slightly different custom macro expectations with specific benefits Zach outlined.
> Because these were already custom macros, I consider this "no harm done". I wouldn't want to go farther than that in this patch though, I'd prefer to get this (or something like it) in place to prove the concept of building more robust libraries that make testing easy and effective. Once we have that, we can write a much more focused patch that *just* tries to improve these particular cases to not require custom macros.
> I'm refraining from commenting on any particulars of the approach you suggest or alternatives for that future time / place / discussion.

Fair enough. I'll wait until this patch lands to propose that.


More information about the llvm-commits mailing list