[PATCH] D34072: Fix alignment bug in COFF emission.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 16:01:52 PDT 2017


ecbeckmann added a comment.

In https://reviews.llvm.org/D34072#778427, @zturner wrote:

> So you're aligning the offset, not the absolute address.  In that it might be more intuitive to isntead of storing `Current`, which is actually a pointer, to store `Base` and `Offset` separately, and only operate on (and align) `Offset`, then compute `Base+Offset` every time you want to write?


Okay, this probably makes the most sense.


https://reviews.llvm.org/D34072





More information about the llvm-commits mailing list