[PATCH] D34064: Allow the gas-style nonstandard SHT_GROUP section.

[Rui Ueyama via llvm-commits]

On Mon, Jun 12, 2017 at 10:43 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
>
> > Index: lld/test/ELF/sht-group-gas-compatibility.test
> > ===================================================================
> > --- /dev/null
> > +++ lld/test/ELF/sht-group-gas-compatibility.test
> > @@ -0,0 +1,16 @@
> > +# GNU assembler seems to create non-standard-compliant SHT_GROUP
> sections.
> > +# Such SHT_GROUP sections use section names as their signatures instead
> of
> > +# symbols pointed by sh_link field.
> > +#
> > +# Since it is prevalent, we accept such nonstandard sections.
>
> Change the reference to gold, since it is the only current producer know
> to create these .o files.  Maybe mention the bug number?
>

Sure. I'll also re-create the object files using gold to make sure that
this patch really works on gold's outputs.


>
> > +  // As a special case, if a symbol is a section symbol and has no name,
> > +  // we use a section name as a signature. Such SHT_GROUP sections are
> > +  // invalid from the perspective of the ELF standard, but GNU linkers
> > +  // accepts them, and their assembler relies on this behavior, so we
> > +  // need a bug-compatibility.
>
> Change reference from gas to gold. Maybe mention the bug number?
>
>
> LGTM with that.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170612/70752442/attachment.html>