[PATCH] D34067: Use symbols with the default version to resolve unversioned symbols.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:755
+// <name>@<version> or <name>@@<version>.
+static void parseSymbolVersion(const SymbolBody &B, uint16_t &Version,
+                               bool &IsDefault, StringRef &NewName) {
----------------
ruiu wrote:
> grimar wrote:
> > So you are mutating arguments here. Generally you are asking to avoid that in reviews. 
> > And I think I agree with that strategy. 
> > Mutating arguments really made me be confusing, please see next comment.
> Well, I tried to use a tuple or a struct to return a value, but turned out this seems the best option I have.
I have one idea in mind for D33680, I would like to show you, sorry again for delay here. I'll polish and update it tomorrow to demonstrate and we can choose which approach fits better then..


https://reviews.llvm.org/D34067