[PATCH] D33716: Provide path to Solaris.h include (Bug 28370)

Joerg Sonnenberger via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 10 08:28:07 PDT 2017


On Sat, Jun 10, 2017 at 11:27:54AM +0300, Fedor Sergeev via llvm-commits wrote:
> On Sat, Jun 10, 2017 at 08:45:20AM +0200, Joerg Sonnenberger wrote:
> > On Sat, Jun 10, 2017 at 01:07:54AM +0300, Fedor Sergeev wrote:
> > > On Fri, Jun 09, 2017 at 11:58:10PM +0200, Joerg Sonnenberger via llvm-commits wrote:
> > > > A sys/regset.h wrapper using #include_next might work just as well, if
> > > > this is the only reason.
> > > 
> > > This wont work for system includes unless you have a full control over system include path
> > > (with something like -isystem).
> > > And that just switches the problem from -include to -isystem.
> > 
> > As long as the Solaris headers use <sys/regset.h> as well and not depend
> > on the relative locations with "", it works well. That's what we do in
> > NetBSD for certain compat overrides for build tools.
> 
> Okey, you dont need -isystem, but you still need to provide platform-specific -I.
> I will try crafting something like that and see how it copes with LLVM build system.

Thanks!

Joerg


More information about the llvm-commits mailing list