[PATCH] D33716: Provide path to Solaris.h include (Bug 28370)

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 14:09:50 PDT 2017


fedor.sergeev added a comment.

In https://reviews.llvm.org/D33716#772362, @krytarowski wrote:

> My personal opinion is that `-include` is the wrong way of doing the work.


While generally I would agree with this sentiment, there is one part of Solaris.h which is very hard to do w/o -include.
I mean all those #undef ES/DS register macro names, that pollute user space after including Solaris sys/regset.h.
You need to perform these undefs immediately after the first include of regset.h, otherwise you are doomed
to hit confusing results of the aforementioned pollution (that nobody else sees on other platforms!).


Repository:
  rL LLVM

https://reviews.llvm.org/D33716





More information about the llvm-commits mailing list