[PATCH] D33892: Align definition of DW_OP_plus with DWARF spec [1/3]

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

In https://reviews.llvm.org/D33892#776908, @aprantl wrote:

> Thanks! I noticed that in the remainder of the patch there are still references to DW_OP_plus left, but they are completely untested. I would recommend removing all referenced to DW_OP_plus in this patch and then adding support for the "real" DW_OP_plus back in a separate commit, together with testcases.


The reason for not yet removing support for DW_OP_plus is because Clang still emits DW_OP_plus, and removing support for DW_OP_plus would break things.

This patch removes a number of test-cases for DW_OP_plus, but some tests remain in MetadataTest.cpp. The plan was to first migrate all (LLVM) uses of DW_OP_plus to DW_OP_plus_uconst in patch [1/3], then to change all Clang uses of DW_OP_plus to DW_OP_plus_uconst in patch [2/3], and then change the meaning of DW_OP_plus in patch [3/3].


https://reviews.llvm.org/D33892