[PATCH] D34034: [LLD][ELF] Make createThunks() iterate until no more thunks added

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 11:02:01 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:1098
+      // create no more Thunks so something must have gone wrong.
+      fatal("Thunk creation not converged in sufficient number of passes");
+  }
----------------
Does this mean you are expecting that it always converges at most two iterations? I'm not sure if that's a correct assumption.


================
Comment at: ELF/Relocations.h:129
 
+  uint32_t Pass = 0;
+
----------------
Please add a comment.


https://reviews.llvm.org/D34034





More information about the llvm-commits mailing list