[PATCH] D33818: [ScheduleDAG] Don't schedule node with physical register interference

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 16:44:00 PDT 2017


efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:552
         SDNode *N = FindCallSeqStart(Node, NestLevel, MaxNest, TII);
+        assert(N && "Must find call sequence start");
 
----------------
javed.absar wrote:
> FindCallSeqStart  - line 476 : assert(Best);  already checks, so this assertion seems redundant
That's true along that particular codepath, but FindCallSeqStart can return null along other codepaths; the assertion isn't obviously redundant.


Repository:
  rL LLVM

https://reviews.llvm.org/D33818





More information about the llvm-commits mailing list