[PATCH] D33937: [ELF] - Allow producing -r output if only empty archive is given.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 7 08:03:40 PDT 2017
grimar added inline comments.
================
Comment at: ELF/Driver.cpp:188
// we'll handle it as if it had a symbol table.
if (!File->hasSymbolTable()) {
for (const auto &P : getArchiveMembers(MBRef))
----------------
ruiu wrote:
> You should check for `!File->isEmpty() && !File->hasSymbolTable()` here instead of making an non-obvious change to LinkerDriver::createFiles.
Thanks. Done.
https://reviews.llvm.org/D33937
More information about the llvm-commits
mailing list