[llvm] r304919 - PR33331 - opt-viewer.py produces broken output for directories with spaces

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 07:57:20 PDT 2017


Author: filcab
Date: Wed Jun  7 09:57:20 2017
New Revision: 304919

URL: http://llvm.org/viewvc/llvm-project?rev=304919&view=rev
Log:
PR33331 - opt-viewer.py produces broken output for directories with spaces

Fix: Properly quote href attributes.

Patch by Simon Whittaker!

Modified:
    llvm/trunk/utils/opt-viewer/optrecord.py

Modified: llvm/trunk/utils/opt-viewer/optrecord.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/opt-viewer/optrecord.py?rev=304919&r1=304918&r2=304919&view=diff
==============================================================================
--- llvm/trunk/utils/opt-viewer/optrecord.py (original)
+++ llvm/trunk/utils/opt-viewer/optrecord.py Wed Jun  7 09:57:20 2017
@@ -33,7 +33,7 @@ def html_file_name(filename):
     return filename.replace('/', '_') + ".html"
 
 def make_link(File, Line):
-    return "{}#L{}".format(html_file_name(File), Line)
+    return "\"{}#L{}\"".format(html_file_name(File), Line)
 
 
 class Remark(yaml.YAMLObject):




More information about the llvm-commits mailing list