[PATCH] D33887: [mips][microMIPS] Extending size reduction pass with ADDIUSP and ADDIUR1SP

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 04:47:47 PDT 2017


sdardis added inline comments.


================
Comment at: lib/Target/Mips/MicroMipsSizeReduction.cpp:35-36
   OT_OperandsAll, ///< Transfer all operands
+  OT_Operands02,  ///< Transfer opernads 0 and 2
+  OT_Operand2,    ///< Transfer just opernad 2
 };
----------------
opernad -> operand.


================
Comment at: lib/Target/Mips/MicroMipsSizeReduction.cpp:259
 
+// Returns true if the value is a valid immediate for ADDIUSP
+static bool AddiuspImmValue(int64_t Value) {
----------------
Full stop at the end of this sentence.


https://reviews.llvm.org/D33887





More information about the llvm-commits mailing list