[PATCH] D33753: [libcxxabi] Add back HandleLLVMOptions for out of tree builds

Eric Fiselier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 02:15:17 PDT 2017


EricWF added a comment.

In https://reviews.llvm.org/D33753#772543, @martell wrote:

> In https://reviews.llvm.org/D33753#772520, @EricWF wrote:
>
> > Your use case isn't the only use case that exists, far from it.
> >
> > I don't want to be duplicating LLVM modules we should just be using directly
>
>
> I think bootstrapping a cross compiler by cross building libc++abi and libc++ is a pretty generic use case.
>  Pulling in all of LLVM's cmake modules depends on top of libc++abi hinders cmake detection when cross building libc++abi standalone.


Then fix LLVM. The in-tree build should act the same as the out-of-tree build.


Repository:
  rL LLVM

https://reviews.llvm.org/D33753





More information about the llvm-commits mailing list