[llvm] r304839 - [CodeGen] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes (NFC).

[Eugene Zelenko via llvm-commits]

Hi, Chandler!

On Tue, Jun 6, 2017 at 4:32 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
> On Tue, Jun 6, 2017 at 3:23 PM Eugene Zelenko via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: eugenezelenko
>> Date: Tue Jun  6 17:22:41 2017
>> New Revision: 304839
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=304839&view=rev
>> Log:
>> [CodeGen] Fix some Clang-tidy modernize-use-using and Include What You Use
>> warnings; other minor fixes (NFC).
>
>
> LLVM has (rightly or wrongly) policy against trying to maintain strict IWYU
> stuff. These kinds of changes tend to have little benefit locally and a high
> cost for outstanding patches, so I'm not sure you should really prioritize
> them.
>
> I think it makes much more sense to clean up *specific files* that you are
> going to be making very substantial changes to. There are some exceptions,
> but they're fairly rare...

I think following IWYU recommendations makes sense. In this patch I
reduced headers' dependencies, what caused problems in other places,
because dependencies were not expressed explicitly.

Eugene.