[PATCH] D33963: [CGP / PowerPC] use direct compares if there's only one load per block in memcmp() expansion

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 16:19:17 PDT 2017


spatel added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:1872
 
-  // Pairwise OR the XOR results.
-  OrList = pairWiseOr(XorList);
-
-  // Pairwise OR the OR results until one result left.
-  while (OrList.size() != 1) {
-    OrList = pairWiseOr(OrList);
+  if (!Cmp) {
+    // Pairwise OR the XOR results.
----------------
efriedma wrote:
> Use of uninitialized variable?
Whoops! Yes...and hmm...no warning from clang.


https://reviews.llvm.org/D33963





More information about the llvm-commits mailing list