[PATCH] D33843: Create a new library called ObjectLayout, and move headers from Support to there.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 19:22:22 PDT 2017

chandlerc added a comment.

In https://reviews.llvm.org/D33843#773575, @zturner wrote:

> In https://reviews.llvm.org/D33843#773565, @chandlerc wrote:
> > Since the name discussion seems winding down, review on the code changes themselves...
> >
> > Generally, there are a lot of unrelated #include order changes. Would it be ok if you (or I) do a widespread clang-format run over the #include lines to get them sorted so that your patch doesn't change that much? I'd like to avoid reverts or build bot trouble due to include order at the same time as trying to land the new library. Remaining (minor) comments inline.
> Where are you seeing these?  I didn't click all 300+ files, but I did click about 20 of them and the only order changes I see are because the new name has a different relative sort order than the old name.  But nothing to do with the old names being unsorted.  So an initial clang-format pass over the files wouldn't do anything.
> If there are specific files you're seeing in that I didn't find, LMK.

There are. Let me try updating them quickly and a rebase should fix it right up.


More information about the llvm-commits mailing list