[PATCH] D33240: [Atomics] Rename and change prototype for atomic memcpy intrinsic

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 19:07:51 PDT 2017


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/one comment addressed before submission.



================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:114
+  // Only expand if there are elements to copy.
+  if (NumElements > 0) {
+    // Don't unfold into illegal integers
----------------
Where did this check come from and why is it needed?  It looks like an attempt to handle a length which isn't an even interval of element size, but the verifier should reject that?


https://reviews.llvm.org/D33240





More information about the llvm-commits mailing list