[PATCH] D33380: Add a dominanance check interface that uses caching for instructions within same basic block.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 13:45:20 PDT 2017


dberlin added a comment.

LGTM with one change to start. I'll add the other pieces of dominators functionality.



================
Comment at: include/llvm/Transforms/Utils/OrderedInstructions.h:41
+  /// Return true if first instruction dominates the second.
+  bool dominates(const Instruction *, const Instruction *);
+
----------------
This should be const and the obbmap mutable



https://reviews.llvm.org/D33380





More information about the llvm-commits mailing list