[PATCH] D33836: [AArch64] Enable FeatureFuseAES for the generic processor model.

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 08:26:49 PDT 2017


On Mon, Jun 5, 2017 at 8:18 AM, Florian Hahn via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> fhahn updated this revision to Diff 101408.
> fhahn marked 2 inline comments as done.
> fhahn added a comment.
>
> Update CHECK- line.
>
> @evandro I’m sorry, I cannot share the exact details for various reasons,
> but it was over 40% on a proprietary benchmark.
>

If you are going to say that you are doing a change for performance
reasons, you really need to be able to motivate it with actual data.


>
> @joelkevinjones unfortunately I cannot share the benchmark we used either,
> and I’m not aware of a publicly-available one.
>
> Fine to not be able to share benchmarks, but if you are going to make a
generic change, you need to make more of an effort than say "can't share
our numbers, don't know of any others".
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170605/eb945ec5/attachment.html>


More information about the llvm-commits mailing list