[PATCH] D33584: Handle non-unique edges in edge-dominance

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 4 21:32:32 PDT 2017


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: unittests/IR/DominatorTreeTest.cpp:302
+
+        ASSERT_TRUE(DT->dominates(Edge_BB0_BB2, BB2));
+        ASSERT_FALSE(DT->dominates(Edge_BB0_BB2, BB1));
----------------
Any reason why these can't be `EXPECT_TRUE` and `EXPECT_FALSE`?


https://reviews.llvm.org/D33584





More information about the llvm-commits mailing list