[PATCH] D33635: [libcxxabi] rework CMakeLists.txt into modules

[Eric Fiselier via Phabricator via llvm-commits]

EricWF added a comment.

In https://reviews.llvm.org/D33635#769583, @martell wrote:

> In https://reviews.llvm.org/D33635#769577, @EricWF wrote:
>
> > Urg... so all of the configuration done in that file is no longer handled?!? That's the opposite of a change that has no effect on functionality...
>
>
> Correct. I would note however that libc++ does not depend on that module either.
>  I believe keeping libc++abi consistent with libc++ makes sense here.
>  Unless someone wants to reintroduce that dependency into libc++?


Libc++ also has some other configuration changes to make that work, like handling LLVM_USE_SANITIZER, which libc++abi doesn't right now but did before...


Repository:
  rL LLVM

https://reviews.llvm.org/D33635