[PATCH] D33444: Fix an issue of creating symlinks when llvm is embedded
Vassil Vassilev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 31 14:06:39 PDT 2017
v.g.vassilev added inline comments.
================
Comment at: cmake/modules/AddLLVM.cmake:220
string(REPLACE ${CMAKE_CFG_INTDIR} ${build_mode} bi ${ARG_BINARY_DIR})
set_target_properties(${target} PROPERTIES "RUNTIME_OUTPUT_DIRECTORY_${CONFIG_SUFFIX}" ${bi})
endif()
----------------
@beanz, for some reason we when configuring we do not enter here. So we do not get a property `RUNTIME_OUTPUT_DIRECTORY_${CONFIG_SUFFIX}`, when calling `add_llvm_tool_symlink` we have CMAKE_CONFIGURATION_TYPES so we enter in the branch where we should have set the property...
https://reviews.llvm.org/D33444
More information about the llvm-commits
mailing list